-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: MapSector system for improved performance and flexibility #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
changed the title
perf: Map Sector by Sayajin
perf: Map Sector by SaiyansKing
Mar 26, 2024
dudantas
approved these changes
Apr 26, 2024
elsongabriel
approved these changes
Apr 26, 2024
What will this change, can you explain to make testing easier? |
uses hashmap instead of node, which is much faster for searching. It's basically where the tiles and creatures in that area are stored, if it's broken, the server won't work. |
dudantas
changed the title
perf: Map Sector by SaiyansKing
enhance: MapSector system for improved performance and flexibility
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new map sector system using a hashmap instead of a node-based structure, which significantly improves search performance. It stores tiles and creatures for each area, and is critical for server functionality.
Credits @SaiyansKing